Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler - support non-blocking scheduled methods #24658

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Scheduler - support non-blocking scheduled methods #24658

merged 1 commit into from
Apr 1, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Mar 31, 2022

@mkouba mkouba requested review from cescoffier and machi1990 March 31, 2022 07:48
@mkouba
Copy link
Contributor Author

mkouba commented Mar 31, 2022 •
edited
Loading

Docs are still missing.

@machi1990
Copy link
Member

I'll love for @cescoffier to have a look on this.

cescoffier
cescoffier requested changes Mar 31, 2022
View reviewed changes
...ment/src/test/java/io/quarkus/scheduler/test/nonblocking/NonBlockingScheduledMethodTest.java Outdated Show resolved Hide resolved
extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/DefaultInvoker.java Show resolved Hide resolved
extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java Outdated Show resolved Hide resolved
extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java Show resolved Hide resolved
...duler/runtime/src/main/java/io/quarkus/scheduler/runtime/SkipConcurrentExecutionInvoker.java Show resolved Hide resolved
...sions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SkipPredicateInvoker.java Show resolved Hide resolved
@mkouba mkouba force-pushed the issue-24621 branch 3 times, most recently from 739d250 to 65e5c7a Compare March 31, 2022 11:00
@mkouba mkouba marked this pull request as ready for review March 31, 2022 11:01
@mkouba mkouba requested a review from cescoffier March 31, 2022 12:19
@mkouba
Copy link
Contributor Author

mkouba commented Mar 31, 2022

@geoand @evanchooly I wonder if this change could help with the implementation of #21428.

@geoand
Copy link
Contributor

geoand commented Mar 31, 2022

It definitely makes it easier.

I'll try and carve out some time to implement it

cescoffier
cescoffier requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a philosophical question because it's Friday, so a great day to have such a kind of discussion...

extensions/scheduler/runtime/src/main/java/io/quarkus/scheduler/runtime/SimpleScheduler.java Show resolved Hide resolved
@mkouba mkouba merged commit ae7abb7 into quarkusio:main Apr 1, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 1, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 1, 2022
@geoand
Copy link
Contributor

geoand commented Apr 4, 2022

I'll try and carve out some time to implement it

See #24741

@mkouba mkouba mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 left review comments

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/documentation area/scheduler kind/enhancement New feature or request
Projects
None yet
Milestone
2.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Scheduler - support non-blocking scheduled methods
4 participants
@mkouba @machi1990 @geoand @cescoffier